Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockdev_commit_backing_mask_off:commit backing mask off #4143

Merged
merged 1 commit into from
Sep 17, 2024
Merged

blockdev_commit_backing_mask_off:commit backing mask off #4143

merged 1 commit into from
Sep 17, 2024

Conversation

aliang123
Copy link
Contributor

When doing block commit with backing_mask_protocol false, the backing raw image format can't be identified as a raw image but the backend image protocol, like nbd, file, iscsi and so on.

id:2807

@aliang123
Copy link
Contributor Author

aliang123 commented Aug 28, 2024 •
edited
Loading

(1/1) Host_RHEL.m9.ux.ovmf.nbd.raw.virtio_scsi.up.virtio_net.Guest.RHEL.9.x.0.x86_64.io-github-autotest-qemu.blockdev_commit_backing_mask_off.q35: PASS (133.26 s)

detailed info:
{"execute": "block-commit", "arguments": {"base-node": "drive_data", "top-node": "drive_sn3", "backing-mask-protocol": false, "device": "drive_sn4", "job-id": "drive_sn4_Rvom"}, "id": "B9vb5E3c"}

#qemu-img info -U /root/avocado/data/avocado-vt/sn4.qcow2 --output=human
image: /root/avocado/data/avocado-vt/sn4.qcow2
file format: qcow2
virtual size: 2 GiB (2147483648 bytes)
disk size: 11 MiB
cluster_size: 65536
backing file: nbd://x.x.x.x:10831
backing file format: nbd

@aliang123
Copy link
Contributor Author

@zhencliu @XueqiangWei @maxujun , please help review it, thanks.

@maxujun
Copy link
Contributor

maxujun commented Sep 3, 2024

(1/1) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.blockdev_commit_backing_mask_off: STARTED
(1/1) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.blockdev_commit_backing_mask_off: CANCEL: Got host qemu version:6.2.0-52, which is not in [9.0.0,) (2.97 s)

Not support from ppc side. LGTM.

@aliang123
blockdev_commit_backing_mask_off:commit backing mask off
767efa4 
When doing block commit with backing_mask_protocol false,
the backing raw image format can't be identified as a raw
image but the backend image protocol, like nbd, file,
iscsi and so on.

Signed-off-by: Aihua Liang <[email protected]>
XueqiangWei
XueqiangWei approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@XueqiangWei XueqiangWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Acked-by: [email protected]

@XueqiangWei XueqiangWei merged commit 5914aee into autotest:master Sep 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhencliu zhencliu zhencliu approved these changes

@XueqiangWei XueqiangWei XueqiangWei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliang123 @maxujun @XueqiangWei @zhencliu